damccorm commented on PR #17782: URL: https://github.com/apache/beam/pull/17782#issuecomment-1142516057
I caught up with Jack briefly, and the takeaways were: 1) If you call TryClaim, you are saying that you are going to attempt to process the data (and it is your restriction's responsibility to handle that). This is consistent with the Java guidance (see https://beam.apache.org/documentation/programming-guide/#user-initiated-checkpoint). 2) Because of this, the residual restriction should _never_ contain a point that the primary restriction has already tried to claim. 3) Currently, for any 0.0 split point, the new primary is `[original.Start, original.Claimed)` and the residual is `[original.Claimed, original.End)`. This is wrong since the residual now contains `original.Claimed`. I've updated my PR to fix this in a general way -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
