damccorm commented on code in PR #17782:
URL: https://github.com/apache/beam/pull/17782#discussion_r886038681
##########
sdks/go/pkg/beam/core/runtime/exec/sdf.go:
##########
@@ -678,10 +678,6 @@ func (n *ProcessSizedElementsAndRestrictions) Checkpoint()
([]*FullValue, error)
return nil, addContext(err)
}
- if !n.rt.IsDone() {
- return nil, addContext(errors.Errorf("Primary restriction %#v
is not done. Check that the RTracker's TrySplit() at fraction 0.0 returns a
completed primary restriction", n.rt))
- }
Review Comment:
I had to remove this check because the new splitting logic ends up setting
`rest.End = rest.claimed + 1`. Since the claimed work _should_ be complete,
this means that the restriction is done, but that condition can't be checked
here without adding new methods for users to implement (which doesn't seem
worth it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
