damccorm commented on code in PR #17782:
URL: https://github.com/apache/beam/pull/17782#discussion_r886879050
##########
sdks/go/pkg/beam/io/rtrackers/offsetrange/offsetrange.go:
##########
@@ -208,9 +210,11 @@ func (tracker *Tracker) GetProgress() (done, remaining
float64) {
return
}
-// IsDone returns true if the most recent claimed element is past the end of
the restriction.
+// IsDone returns true if the most recent claimed element is past the end of
the restriction
+// or if the restriction represents no work to be done (aka the start of the
restriction is
+// greater than or equal to the end).
func (tracker *Tracker) IsDone() bool {
- return tracker.err == nil && tracker.claimed >= tracker.rest.End
+ return tracker.err == nil && (tracker.claimed >= tracker.rest.End ||
tracker.rest.Start >= tracker.rest.End)
Review Comment:
Yeah, you're right - updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
