parthchandra commented on code in PR #297:
URL: https://github.com/apache/datafusion-comet/pull/297#discussion_r1575356501
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -426,6 +426,42 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde {
} else {
None
}
+ case variance @ VarianceSamp(child, nullOnDivideByZero) =>
+ val childExpr = exprToProto(child, inputs, binding)
+ val dataType = serializeDataType(variance.dataType)
+
+ if (childExpr.isDefined && dataType.isDefined) {
+ val varBuilder = ExprOuterClass.VarianceSample.newBuilder()
+ varBuilder.setChild(childExpr.get)
+ varBuilder.setNullOnDivideByZero(nullOnDivideByZero)
+ varBuilder.setDatatype(dataType.get)
+
+ Some(
+ ExprOuterClass.AggExpr
+ .newBuilder()
+ .setVarianceSample(varBuilder)
+ .build())
+ } else {
+ None
Review Comment:
Could you add the explainPlan info here as well?
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -426,6 +426,42 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde {
} else {
None
}
+ case variance @ VarianceSamp(child, nullOnDivideByZero) =>
+ val childExpr = exprToProto(child, inputs, binding)
+ val dataType = serializeDataType(variance.dataType)
+
+ if (childExpr.isDefined && dataType.isDefined) {
+ val varBuilder = ExprOuterClass.VarianceSample.newBuilder()
+ varBuilder.setChild(childExpr.get)
+ varBuilder.setNullOnDivideByZero(nullOnDivideByZero)
+ varBuilder.setDatatype(dataType.get)
+
+ Some(
+ ExprOuterClass.AggExpr
+ .newBuilder()
+ .setVarianceSample(varBuilder)
+ .build())
+ } else {
+ None
+ }
+ case variancePop @ VariancePop(child, nullOnDivideByZero) =>
+ val childExpr = exprToProto(child, inputs, binding)
+ val dataType = serializeDataType(variancePop.dataType)
+
+ if (childExpr.isDefined && dataType.isDefined) {
+ val varBuilder = ExprOuterClass.VariancePopulation.newBuilder()
+ varBuilder.setChild(childExpr.get)
+ varBuilder.setNullOnDivideByZero(nullOnDivideByZero)
+ varBuilder.setDatatype(dataType.get)
+
+ Some(
+ ExprOuterClass.AggExpr
+ .newBuilder()
+ .setVariancePopulation(varBuilder)
+ .build())
+ } else {
+ None
Review Comment:
ditto, add the explainPlan info here as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
