andygrove commented on code in PR #297:
URL: https://github.com/apache/datafusion-comet/pull/297#discussion_r1576321475
##########
core/src/execution/proto/expr.proto:
##########
@@ -165,6 +167,18 @@ message CovPopulation {
DataType datatype = 4;
}
+message VarianceSample {
+ Expr child = 1;
+ bool null_on_divide_by_zero = 2;
+ DataType datatype = 3;
+}
+
+message VariancePopulation {
+ Expr child = 1;
+ bool null_on_divide_by_zero = 2;
+ DataType datatype = 3;
+}
Review Comment:
I don't think we need to have the same struct defined twice here because we
have separate field tags (14 and 15) in AggExpr to represent the two different
expressions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
