huaxingao commented on code in PR #297:
URL: https://github.com/apache/datafusion-comet/pull/297#discussion_r1577073541
##########
core/src/execution/proto/expr.proto:
##########
@@ -165,6 +167,18 @@ message CovPopulation {
DataType datatype = 4;
}
+message VarianceSample {
+ Expr child = 1;
+ bool null_on_divide_by_zero = 2;
+ DataType datatype = 3;
+}
+
+message VariancePopulation {
+ Expr child = 1;
+ bool null_on_divide_by_zero = 2;
+ DataType datatype = 3;
+}
Review Comment:
Thanks for your comment @andygrove
I am not sure if there is a way to access the field tag. I added an enum
`StatisticsType` so I don't need two structs for `VarianceSample` and
`VariancePopulation`. Also I think adding a `StatisticsType` is more consistent
with the implementation in `variance.rs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
