jayzhan211 commented on issue #10074:
URL: https://github.com/apache/datafusion/issues/10074#issuecomment-2088004947
I'm thinking of moving `AggregateUDFImpl` to `aggregate-common`, which
imports both physical-common and expr-common. Then, we import
`AggregateUDFImpl` in `datafusion-expr`.
The overall idea is to enable us to import **common** things to
`Expr::AggregateFunction` which lives in `datafusion-expr`.
Those **common** things mainly include `AggregateUDFImpl` and of course,
physical-expr `AggregateExpr`. Although, having a `physical-expr` idea in the
logical layer is quite counter-intuitive, if we consider it as **common** level
thing, it is not a weird thing. But, I need to play around with it to see if I
miss something.
```mermaid
graph TD;
functions-aggregates-common-->expr-common;
functions-aggregates-common-->physical-expr-common;
functions-aggregates-->functions-aggregates-common;
physical-expr-common-->expr-common;
expr-->expr-common;
expr-->functions-aggregates-common;
physical-expr-->physical-expr-common;
core-->functions-aggregates;
core-->physical-expr;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
