alamb commented on issue #10074: URL: https://github.com/apache/datafusion/issues/10074#issuecomment-2089174413
> The overall idea is to enable us to import common things to Expr::AggregateFunction which lives in datafusion-expr. In the chart you have in https://github.com/apache/datafusion/issues/10074#issuecomment-2088004947 it seems like it will mean that `datafusion-expr` will depend (indirectly) on `datafusion-physical-expr` which I thought was the dependency we are trying to avoid I am sorry I am so slow to respond and getting lost here. Can we take a step back and help figure out what problem we are trying to solve Can you remind me why `datafusion-functions-aggregate` (the implementation of aggregate functions) shouldn't depend on `datafusion-physical-expr` and `datafusion-expr`? I thought the thing we are trying to do is avoid `datafusion-expr` depending on `datafusion-physical-expr` 🤔 What I believe we are trying to do is to pull the aggregate functions out of datafusion-physical-expr I am sorry if you have explained this to me already. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
