tshauck commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1593350009
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -1024,7 +1024,25 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
}
+ test("unhex") {
+ val table = "unhex_table"
+ withTable(table) {
+ sql(s"create table $table(col string) using parquet")
+
+ sql(s"""INSERT INTO $table VALUES
+ |('537061726B2053514C'),
+ |('737472696E67'),
+ |('\0'),
+ |(''),
+ |('###'),
+ |('G123'),
+ |('hello'),
+ |('A1B'),
+ |('0A1B')""".stripMargin)
+ checkSparkAnswerAndOperator(s"SELECT unhex(col) FROM $table")
Review Comment:
Made an update in
https://github.com/apache/datafusion-comet/pull/342/commits/36baf8e87dd2689baf8c45961c7ed34a97f1f493
that seems to work
(https://github.com/tshauck/arrow-datafusion-comet/actions/runs/8994978806).
Happy to get any feedback about the approach taken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
