andygrove commented on code in PR #342:
URL: https://github.com/apache/datafusion-comet/pull/342#discussion_r1594082373
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -1024,7 +1024,27 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
}
+ test("unhex") {
+ assume(!isSpark32, "unhex function has incorrect behavior in 3.2")
Review Comment:
```suggestion
// When running against Spark 3.2, we include a bug fix for
https://issues.apache.org/jira/browse/SPARK-40924 that
// was added in Spark 3.3, so although Comet's behavior is more correct
when running against Spark 3.2, it is not
// the same (and this only applies to edge cases with hex inputs with
lengths that are not divisible by 2)
assume(!isSpark32, "unhex function has incorrect behavior in 3.2")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
