andygrove commented on code in PR #415:
URL: https://github.com/apache/datafusion-comet/pull/415#discussion_r1597445759
##########
core/src/execution/proto/expr.proto:
##########
@@ -233,12 +233,20 @@ message Remainder {
DataType return_type = 4;
}
+enum EvalMode {
+ LEGACY = 0;
+ TRY = 1;
+ ANSI = 2;
+}
+
message Cast {
Expr child = 1;
DataType datatype = 2;
string timezone = 3;
- // LEGACY, ANSI, or TRY
- string eval_mode = 4;
+ // Depreciateid: LEGACY, ANSI, or TRY - preserved for backward compatibity
Review Comment:
No need for backwards compatibility here since we have not published a
release yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
