andygrove commented on code in PR #415:
URL: https://github.com/apache/datafusion-comet/pull/415#discussion_r1597446255
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -1207,7 +1223,7 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde {
.newBuilder()
.setChild(e)
.setDatatype(serializeDataType(IntegerType).get)
- .setEvalMode("LEGACY") // year is not affected by ANSI mode
+ .setEvalMode(stringToEvalMode("LEGACY")) // year is not
affected by ANSI mode
Review Comment:
You can just use the enum directly here rather than convert from string.
```suggestion
// year is not affected by ANSI mode so we use LEGACY
mode here
.setEvalMode(ExprOuterClass.EvalMode.LEGACY)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
