andygrove commented on code in PR #415:
URL: https://github.com/apache/datafusion-comet/pull/415#discussion_r1597446354
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -525,6 +527,18 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde {
* @return
* The protobuf representation of the expression, or None if the
expression is not supported
*/
+
+ def stringToEvalMode(evalModeStr: String): ExprOuterClass.EvalMode =
+ evalModeStr.toUpperCase(Locale.ROOT) match {
+ case "LEGACY" => ExprOuterClass.EvalMode.LEGACY
+ case "TRY" => ExprOuterClass.EvalMode.TRY
+ case "ANSI" => ExprOuterClass.EvalMode.ANSI
+ case _ =>
+ throw new IllegalArgumentException(
+ "Invalid eval mode"
Review Comment:
It would be good to include the invalid value in the error message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
