alamb opened a new pull request, #10500:
URL: https://github.com/apache/datafusion/pull/10500

   ## Which issue does this PR close?
   
   Part of Closes https://github.com/apache/datafusion/issues/10294
   
   ## Rationale for this change
   
   
   
   While working on https://github.com/apache/datafusion/pull/10489 I spent 
some time studying `PullUpCorrelatedExpr` as it  wasn't clear to me what was 
different about the two callsites.
   
   While I was in here I figured I would refactor things into a structure to 
make it easier to understand for my future self (and hopefully other readers)
   
   ## What changes are included in this PR?
   
   1. Add `PullUpCorrelatedExpr::new` and improve documentation
   2. Improve some documentation
   
   ## Are these changes tested?
   Covered by existing CI
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   3. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are 
they covered by existing tests)?
   -->
   
   ## Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be 
updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api 
change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to