alamb commented on code in PR #10500:
URL: https://github.com/apache/datafusion/pull/10500#discussion_r1604203770
##########
datafusion/optimizer/src/decorrelate.rs:
##########
@@ -38,23 +38,63 @@ use
datafusion_physical_expr::execution_props::ExecutionProps;
/// 'Filter'. It adds the inner reference columns to the 'Projection' or
/// 'Aggregate' of the subquery if they are missing, so that they can be
/// evaluated by the parent operator as the join condition.
+#[derive(Debug)]
pub struct PullUpCorrelatedExpr {
pub join_filters: Vec<Expr>,
- // mapping from the plan to its holding correlated columns
+ /// mapping from the plan to its holding correlated columns
pub correlated_subquery_cols_map: HashMap<LogicalPlan, BTreeSet<Column>>,
pub in_predicate_opt: Option<Expr>,
- // indicate whether it is Exists(Not Exists) SubQuery
+ /// Is this an Exists(Not Exists) SubQuery. Defaults to false
pub exists_sub_query: bool,
- // indicate whether the correlated expressions can pull up or not
+ /// Can the correlated expressions be pulled up. Defaults to **TRUE**
pub can_pull_up: bool,
- // indicate whether need to handle the Count bug during the pull up process
+ /// Do we need to handle the Count bug during the pull up process
Review Comment:
I filed https://github.com/apache/datafusion/pull/10500 to track this issue
(thanks @comphead and everyone for calling it out and the context) and added a
reference to the ticket in the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
