alamb commented on code in PR #10500:
URL: https://github.com/apache/datafusion/pull/10500#discussion_r1599837869
##########
datafusion/optimizer/src/decorrelate_predicate_subquery.rs:
##########
@@ -248,16 +248,10 @@ fn build_join(
let subquery = query_info.query.subquery.as_ref();
let subquery_alias = alias.next("__correlated_sq");
- let mut pull_up = PullUpCorrelatedExpr {
- join_filters: vec![],
- correlated_subquery_cols_map: Default::default(),
- in_predicate_opt: in_predicate_opt.clone(),
- exists_sub_query: in_predicate_opt.is_none(),
- can_pull_up: true,
- need_handle_count_bug: false,
- collected_count_expr_map: Default::default(),
- pull_up_having_expr: None,
- };
+ let mut pull_up = PullUpCorrelatedExpr::new()
+ .with_in_predicate_opt(in_predicate_opt.clone())
Review Comment:
these were the two fields that are set differently which I think is much
clearer now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
