yyy1000 commented on code in PR #10494:
URL: https://github.com/apache/datafusion/pull/10494#discussion_r1600571039
##########
datafusion/optimizer/src/propagate_empty_relation.rs:
##########
@@ -154,14 +156,14 @@ impl OptimizerRule for PropagateEmptyRelation {
Ok(Transformed::yes(LogicalPlan::Projection(
Projection::new_from_schema(
Arc::new(child),
- plan.schema().clone(),
+ input_schema.clone(),
),
)))
}
} else {
Ok(Transformed::yes(LogicalPlan::Union(Union {
inputs: new_inputs,
- schema: union.schema.clone(),
+ schema: input_schema.clone(),
Review Comment:
Or from earlier, what if when we build the schema for `Project` and the
input for the `Project` is an `Alias`, we use Alias's expr name rather than
Alias's name. 🤔 I'm not sure whether it would break some criteria.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
