alamb commented on code in PR #10494:
URL: https://github.com/apache/datafusion/pull/10494#discussion_r1602014671
##########
datafusion/optimizer/src/propagate_empty_relation.rs:
##########
@@ -154,14 +156,14 @@ impl OptimizerRule for PropagateEmptyRelation {
Ok(Transformed::yes(LogicalPlan::Projection(
Projection::new_from_schema(
Arc::new(child),
- plan.schema().clone(),
+ input_schema.clone(),
),
)))
}
} else {
Ok(Transformed::yes(LogicalPlan::Union(Union {
inputs: new_inputs,
- schema: union.schema.clone(),
+ schema: input_schema.clone(),
Review Comment:
It looks like LogicalPlanBuilder::union has the code to do the schema
coercion / matching
https://github.com/apache/datafusion/blob/405a5f60406f8e2757d2d6fb8e3cc46094aa8ed7/datafusion/expr/src/logical_plan/builder.rs#L1365-L1429
So perhaps we need to either:
1. Fix the `LogicalPlanBuilder` code
2. Update optimizer passes to not create `LogicalPlan::Union` directly but
instead use the builder (and thus apply the schema rationalization to occur)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
