berkaysynnada commented on code in PR #10510:
URL: https://github.com/apache/datafusion/pull/10510#discussion_r1601146396
##########
datafusion/expr/src/interval_arithmetic.rs:
##########
@@ -1469,6 +1472,8 @@ pub enum NullableInterval {
MaybeNull { values: Interval },
/// The value is definitely not null, and is within the specified range.
NotNull { values: Interval },
+ /// Added to handle cases with insufficient statistics
+ Unknown,
}
Review Comment:
Using ScalarValue::Null for representing unbounded intervals is discouraged.
Although it's possible to construct these, performing arithmetic on them is not
feasible. Could you detect the datatype and instead create
ScalarValue::Datatype(None)? This approach is consistent with how we handle
unbounded cases throughout the codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
