berkaysynnada commented on code in PR #10510:
URL: https://github.com/apache/datafusion/pull/10510#discussion_r1601184358
##########
datafusion/expr/src/interval_arithmetic.rs:
##########
@@ -1469,6 +1472,8 @@ pub enum NullableInterval {
MaybeNull { values: Interval },
/// The value is definitely not null, and is within the specified range.
NotNull { values: Interval },
+ /// Added to handle cases with insufficient statistics
+ Unknown,
}
Review Comment:
I get the problem now. These unbounded intervals are meant to represent the
uncertainty in the data. Adding another 'unknown' variant does seem like a
burden, but you're right, it looks like the only way with the current
ColumnStatistics. In the long run, probably the best fix is to add a DataType
to the ColumnStatistic struct because I remember missing datatype info caused
issues before too. But that's for another time, not this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
