alamb commented on code in PR #10510:
URL: https://github.com/apache/datafusion/pull/10510#discussion_r1602174322
##########
datafusion/expr/src/interval_arithmetic.rs:
##########
@@ -1469,6 +1472,8 @@ pub enum NullableInterval {
MaybeNull { values: Interval },
/// The value is definitely not null, and is within the specified range.
NotNull { values: Interval },
+ /// Added to handle cases with insufficient statistics
+ Unknown,
}
Review Comment:
I was trying to suggest that anywhere we have `ColumnStatistics ` we should
also have access to the corresponding `Schema`
So like where in the code is the `ColumnStatistics` you are converting to
`NullableInterval`
##########
datafusion/expr/src/interval_arithmetic.rs:
##########
@@ -1469,6 +1472,8 @@ pub enum NullableInterval {
MaybeNull { values: Interval },
/// The value is definitely not null, and is within the specified range.
NotNull { values: Interval },
+ /// Added to handle cases with insufficient statistics
+ Unknown,
}
Review Comment:
I was trying to suggest that anywhere we have `ColumnStatistics ` we should
also have access to the corresponding `Schema`
So like where in the code is the `ColumnStatistics` you are converting to
`NullableInterval`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
