viirya commented on code in PR #407:
URL: https://github.com/apache/datafusion-comet/pull/407#discussion_r1602236634
##########
spark/src/main/scala/org/apache/spark/sql/comet/execution/shuffle/CometShuffleExchangeExec.scala:
##########
@@ -454,12 +458,13 @@ class CometShuffleWriteProcessor(
new
SQLShuffleWriteMetricsReporter(context.taskMetrics().shuffleWriteMetrics,
metrics)
}
+ // FIXME: we need actually prev of rdd?
override def write(
- rdd: RDD[_],
+ inputs: Iterator[_],
Review Comment:
If the input iterator has partitionId, we still need to get rid of it. I
don't run this but looks like this will cause failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
