viirya commented on code in PR #407:
URL: https://github.com/apache/datafusion-comet/pull/407#discussion_r1602259528
##########
spark/src/main/scala/org/apache/spark/sql/comet/DecimalPrecision.scala:
##########
@@ -107,11 +108,4 @@ object DecimalPrecision {
case e => e
}
}
-
- object DecimalExpression {
- def unapply(e: Expression): Option[(Int, Int)] = e.dataType match {
- case t: DecimalType => Some((t.precision, t.scale))
- case _ => None
- }
- }
Review Comment:
But I think this `DecimalExpression.unapply` also works for Spark 4.0 right?
We don't need to use `DecimalExpression` if current approach works both for
Spark 3.x and Spark 4.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
