viirya commented on code in PR #407:
URL: https://github.com/apache/datafusion-comet/pull/407#discussion_r1602260691
##########
spark/src/main/scala/org/apache/spark/sql/comet/execution/shuffle/CometShuffleExchangeExec.scala:
##########
@@ -454,12 +458,13 @@ class CometShuffleWriteProcessor(
new
SQLShuffleWriteMetricsReporter(context.taskMetrics().shuffleWriteMetrics,
metrics)
}
+ // FIXME: we need actually prev of rdd?
override def write(
- rdd: RDD[_],
+ inputs: Iterator[_],
Review Comment:
Yea, I mean for Spark 4.0 case, we also need to get rid of the partition. I
saw you replied my other comment:
https://github.com/apache/datafusion-comet/pull/407#discussion_r1602237566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
