vidyasankarv commented on PR #383:
URL: https://github.com/apache/datafusion-comet/pull/383#issuecomment-2116614807

   > @vidyasankarv I would suggest that we skip the test for now when running 
against Spark 3.2 and file a follow on issue to fix 3.2 compatibility (this may 
not be a high priority since 3.2 is quite old and we should consider dropping 
support for it at some point.
   > 
   > You can add an `assume` call to the test to skip for certain criteria:
   > 
   > ```scala
   >   test("cast StringType to DateType") {
   >     assume(CometSparkSessionExtensions.isSpark33Plus)
   > ```
   > 
   > It would be good to add a comment in here as well with a link to the 
follow on issue (could you file that?)
   
   @andygrove thank you for suggestions - filed this issue 
https://github.com/apache/datafusion-comet/issues/440 and linked in the test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to