vidyasankarv commented on PR #383: URL: https://github.com/apache/datafusion-comet/pull/383#issuecomment-2120433348
https://github.com/apache/datafusion-comet/suites/23883332179/logs?attempt=2 In the logs for ubuntu-latest/java 17-spark-3.4-scala-2.12/java - which included the fuzz test dates - all return cast values on comet side are showing null. Additionally sample dates that pass otherwise without fuzz test https://github.com/apache/datafusion-comet/pull/383/files#diff-41ecdd113d7a7afe33447e34f1ff0b5ed3033a89bfbcefa9e7e259d7a6e4daecR577-R585 also report as null on Comet side when the fuzz tests are included. https://github.com/apache/datafusion-comet/actions/runs/9123082449/job/25132235801 ``` ![262142-01-01,2142-01-01] [262142-01-01,null] ![262142-01-01 ,2142-01-01] [262142-01-01 ,null] ![262142-01-01T ,2142-01-01] [262142-01-01T ,null] ![262142-01-01T 123123123,2142-01-01] [262142-01-01T 123123123,null] [263,null] [263,null] ``` if you search for `262142-01-01` in the logs you can see it reports as failing on lines 14035 to 14038 as above similarly if you also search for dates `-262143-12-31` on lines 10167 to 10171 ``` [--262143-12-31,null] [--262143-12-31,null] [--262143-12-31T 1234 ,null] [--262143-12-31T 1234 ,null] ![-262143-12-31,2144-12-31] [-262143-12-31,null] ![-262143-12-31 ,2144-12-31] [-262143-12-31 ,null] ![-262143-12-31T,2144-12-31] [-262143-12-31T,null] ![-262143-12-31T ,2144-12-31] [-262143-12-31T ,null] ![-262143-12-31T 123123123,2144-12-31] [-262143-12-31T 123123123,null] ``` the return value of comet is reported as null I have spent a fair time trying to understand why this is happening and also added some more samples from fuzzy dates into my current unit tests in rust tests and CometCastSuite all of them are passing. So I might need some help in trying to identify the issue with fuzz test. Apologies for taking your time on this again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
