andygrove commented on code in PR #461:
URL: https://github.com/apache/datafusion-comet/pull/461#discussion_r1612317278
##########
core/src/execution/datafusion/expressions/cast.rs:
##########
@@ -644,14 +644,16 @@ impl Cast {
| DataType::Float32
| DataType::Float64
),
- DataType::Decimal128(_, _) => matches!(
+ DataType::Decimal128(_, _) | DataType::Decimal256(_, _) =>
matches!(
Review Comment:
If I remove the decimal 256 support here, I get this test failure:
```
- Fix NPE in partial decimal sum *** FAILED *** (119 milliseconds)
org.apache.spark.SparkException: Job aborted due to stage failure: Task 0
in stage 190.0 failed 1 times, most recent failure: Lost task 0.0 in stage
190.0 (TID 468) (192.168.86.33 executor driver):
org.apache.comet.CometNativeException: Execution error: Comet Internal Error:
Native cast invoked for unsupported cast from Decimal128(5, 2) to Decimal256(5,
2)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
