andygrove commented on code in PR #461:
URL: https://github.com/apache/datafusion-comet/pull/461#discussion_r1612492325
##########
core/src/execution/datafusion/expressions/cast.rs:
##########
@@ -503,41 +503,37 @@ impl Cast {
fn cast_array(&self, array: ArrayRef) -> DataFusionResult<ArrayRef> {
let to_type = &self.data_type;
let array = array_with_timezone(array, self.timezone.clone(),
Some(to_type));
+ let from_type = array.data_type().clone();
+
+ // unpack dictionary string arrays first
+ // TODO: we are unpacking a dictionary-encoded array and then
performing
+ // the cast. We could potentially improve performance here by casting
the
+ // dictionary values directly without unpacking the array first,
although this
+ // would add more complexity to the code
+ let array = match &from_type {
+ DataType::Dictionary(key_type, value_type)
+ if key_type.as_ref() == &DataType::Int32
+ && (value_type.as_ref() == &DataType::Utf8
+ || value_type.as_ref() == &DataType::LargeUtf8) =>
+ {
+ cast_with_options(&array, value_type.as_ref(), &CAST_OPTIONS)?
+ }
+ _ => array,
+ };
Review Comment:
We were previously unpacking dictionary-encoded string arrays only for
string to int and string to date. I just moved it earlier on so that we don't
have to handle it specifically for certain casts from string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
