alamb commented on PR #10711: URL: https://github.com/apache/datafusion/pull/10711#issuecomment-2142179438
> I'd like the idea to use the partial specialization for Decimal, I am actually thinking of passing an array to the make_stats_iterator macro to make it more generic. However, in opposite, we will lose some validation abilities. I think using a `&[&ParquetStatistics]` (aka an array of references to statistics) would be good. Let's ensure it doesn't need `&[ParquetStatistics]` (an array of references to owned statistics) as I would like very much to be able to only evaluate this code for row groups that we haven't already filtered out (aka I want to be able to filter the statistics prior to passing down here) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
