xinlifoobar commented on PR #10711: URL: https://github.com/apache/datafusion/pull/10711#issuecomment-2142516238
> the other obvious thing to do in this PR might be to use a macro to avoid the copy/paste between min_statistics and max_statistics... > > So I guess the question is "shall we keep working on this PR or shall we plan to work on it as a follow on PR" 🤔 How about we merge this and do all the listings in later PRs. Personally, I think to keep a long history of PR may not a good practice. Some following I may thing: 1. Merging the make_statistics_iter and make_decimal_statistics_iter using `&[&ParquetStatistics]` 2. Avoid the duplicate code of min_statistics and max_statistcs, could be another macro to concat `Min`/`Max` and `StatisticIterator`? 3. Complete the implementations of statistics for Timestamp and Dictionary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
