xinlifoobar commented on PR #10711: URL: https://github.com/apache/datafusion/pull/10711#issuecomment-2148806273
> I think we have now filled out support for the other data types, so perhaps we can revisit the code in this PR again. What do you think @xinlifoobar ? Hey @alamb, I just republished this PR with some major changes including: - Add types we missed in previous there. - Play around with the [`paste! `](https://crates.io/crates/paste) macro which I found it may useful here to remove the duplicate codes. (Feel free to revert the change though). I also play around the `make_stats_iterator` and `make_decimal_stats_iterator` with the paste macro... which made the code difficult to read. Here I recommend keeping them separately and clean. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
