edmondop commented on PR #10728:
URL: https://github.com/apache/datafusion/pull/10728#issuecomment-2152980469
> > Yes I was stuck because one test doesn't pass, will need to investigate
unless you have some hints to share
>
> If you referring to CI test failed, it is
>
> ```
> left: (0, "+----+----+-------------+------------+")
> right: (0, "+----+----+-------------+-------------+")
> ```
>
> which should probably be straightforward to fix, we can check row counts
first?
Thanks for the tip, checking for the row count effectively show that the
right_join filtered return a different number of rows when using SMJ and
HashJoin. What could be the root cause?
I have tried to modify the column used for the filter un-commenting the
section commented below, but this breaks all the other test cases too
```rust
fn less_than_10_join_filter(schema1: Arc<Schema>, _schema2: Arc<Schema>) ->
JoinFilter {
let less_than_100 = Arc::new(BinaryExpr::new(
Arc::new(Column::new("a", 0)),
Operator::Lt,
Arc::new(Literal::new(ScalarValue::from(100))),
)) as _;
let column_indices = vec![
ColumnIndex {
index: 0,
side: JoinSide::Left,
},
// ColumnIndex {
// index: 0,
// side: JoinSide::Right,
// },
];
let intermediate_schema =
Schema::new(vec![schema1.field_with_name("a").unwrap().to_owned()]);
JoinFilter::new(less_than_100, column_indices, intermediate_schema)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
