comphead commented on code in PR #10728:
URL: https://github.com/apache/datafusion/pull/10728#discussion_r1635177813
##########
datafusion/core/tests/fuzz_cases/join_fuzz.rs:
##########
@@ -40,92 +45,207 @@ use test_utils::stagger_batch_with_seed;
#[tokio::test]
async fn test_inner_join_1k() {
- run_join_test(
+ JoinFuzzTestCase::new(
+ make_staggered_batches(1000),
+ make_staggered_batches(1000),
+ JoinType::Inner,
+ None,
+ )
+ .run_test()
+ .await
+}
+
+fn less_than_10_join_filter(schema1: Arc<Schema>, _schema2: Arc<Schema>) ->
JoinFilter {
+ let less_than_100 = Arc::new(BinaryExpr::new(
+ Arc::new(Column::new("a", 0)),
+ Operator::Lt,
+ Arc::new(Literal::new(ScalarValue::from(100))),
+ )) as _;
+ let column_indices = vec![ColumnIndex {
+ index: 0,
+ side: JoinSide::Left,
+ }];
+ let intermediate_schema =
+ Schema::new(vec![schema1.field_with_name("a").unwrap().to_owned()]);
+
+ JoinFilter::new(less_than_100, column_indices, intermediate_schema)
+}
+
+#[tokio::test]
+async fn test_inner_join_1k_filtered() {
+ JoinFuzzTestCase::new(
+ make_staggered_batches(1000),
+ make_staggered_batches(1000),
+ JoinType::Inner,
+ Some(Box::new(less_than_10_join_filter)),
+ )
+ .run_test()
+ .await
+}
+
+#[tokio::test]
+async fn test_inner_join_1k_smjoin() {
+ JoinFuzzTestCase::new(
make_staggered_batches(1000),
make_staggered_batches(1000),
JoinType::Inner,
+ None,
)
+ .run_test()
.await
}
#[tokio::test]
async fn test_left_join_1k() {
- run_join_test(
+ JoinFuzzTestCase::new(
+ make_staggered_batches(1000),
+ make_staggered_batches(1000),
+ JoinType::Left,
+ None,
+ )
+ .run_test()
+ .await
+}
+
+#[tokio::test]
+async fn test_left_join_1k_filtered() {
+ JoinFuzzTestCase::new(
make_staggered_batches(1000),
make_staggered_batches(1000),
JoinType::Left,
+ Some(Box::new(less_than_10_join_filter)),
)
+ .run_test()
.await
}
+// Add support for RightJoins
+#[ignore]
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
