alamb commented on code in PR #10813:
URL: https://github.com/apache/datafusion/pull/10813#discussion_r1630062508
##########
datafusion/core/src/datasource/physical_plan/parquet/access_plan.rs:
##########
@@ -366,7 +410,8 @@ mod test {
RowSelector::select(10),
// selectors from the second row group
RowSelector::select(5),
- RowSelector::skip(7)
+ RowSelector::skip(7),
Review Comment:
turns out that some of the existing unit tests were actually invalid.
However, I think the issues are actually test problem, not actual code
problems. All the actual parquet reader tests passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
