Jefffrey commented on code in PR #10813:
URL: https://github.com/apache/datafusion/pull/10813#discussion_r1632036259
##########
datafusion/core/src/datasource/physical_plan/parquet/opener.rs:
##########
@@ -212,3 +213,34 @@ impl FileOpener for ParquetOpener {
}))
}
}
+
+/// Return the initial [`ParquetAccessPlan`]
+///
+/// If the user has supplied one as an extension, use that
+/// otherwise return a plan that scans all row groups
+///
+/// Returns an error is an invalid `ParquetAccessPlan` is provided
+///
+/// Note: path is only used for error messages
Review Comment:
```suggestion
/// Returns an error if an invalid `ParquetAccessPlan` is provided
///
/// Note: file_name is only used for error messages
```
##########
datafusion/core/src/datasource/physical_plan/parquet/access_plan.rs:
##########
@@ -182,6 +183,11 @@ impl ParquetAccessPlan {
/// is returned for *all* the rows in the row groups that are not skipped.
/// Thus it includes a `Select` selection for any [`RowGroupAccess::Scan`].
///
+ /// # Errors
+ ///
+ /// Returns an error if the specified row selection does not specify
+ /// the same number of rows as in `row_group_metadata`.
Review Comment:
```suggestion
/// Returns an error if any specified row selection does not specify
/// the same number of rows as in it's corresponding
`row_group_metadata`.
```
Is it also worth making a note that it's up to the caller to validate that
the size of the ParquetAccessPlan matches the number of row groups?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
