alamb commented on code in PR #10813:
URL: https://github.com/apache/datafusion/pull/10813#discussion_r1630064322
##########
datafusion/core/src/datasource/physical_plan/parquet/opener.rs:
##########
@@ -139,7 +139,8 @@ impl FileOpener for ParquetOpener {
let predicate = pruning_predicate.as_ref().map(|p| p.as_ref());
let rg_metadata = file_metadata.row_groups();
// track which row groups to actually read
- let access_plan = ParquetAccessPlan::new_all(rg_metadata.len());
+ let access_plan =
Review Comment:
This is the required plumbing, which I am quite pleased with -- it is quite
straightforward now
##########
datafusion/core/src/datasource/physical_plan/parquet/access_plan.rs:
##########
@@ -239,7 +245,32 @@ impl ParquetAccessPlan {
.iter()
.any(|rg| matches!(rg, RowGroupAccess::Selection(_)))
{
- return None;
+ return Ok(None);
+ }
+
+ // validate all Selections
+ for (idx, (rg, rg_meta)) in self
Review Comment:
This is new checking added as users can pass in `ParquetAccessPlan` and the
semantics are quite subtle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
