Lordworms commented on issue #10710:
URL: https://github.com/apache/datafusion/issues/10710#issuecomment-2156804973

   > Thanks for looking into these issues @Lordworms! If there are any changes 
you want to make in the substrait integration test repo itself, I'll gladly do 
those reviews for you as well!
   
   Hi @richtia , I just find in some confusion in 
[tpch_1_json](https://github.com/substrait-io/consumer-testing/blob/main/substrait_consumer/tests/integration/queries/tpch_substrait_plans/query_1_plan.json)
   
   in general tpch1, the filter looks like 
   <img width="409" alt="image" 
src="https://github.com/apache/datafusion/assets/48054792/859bb956-267a-4aea-8df2-ee25db096104";>
   but in this repo, the actual tpch_1 you use is like
   <img width="468" alt="image" 
src="https://github.com/apache/datafusion/assets/48054792/ab246b4d-e73a-4c11-a083-6951cc67c144";>
   
   Is there any purposes of adding the extra interval?
   
   Thanks a lot


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to