Re: [I] Integrate with the substrait integration test [datafusion]

[via GitHub]

richtia commented on issue #10710:
URL: https://github.com/apache/datafusion/issues/10710#issuecomment-2156807602

   > > Thanks for looking into these issues @Lordworms! If there are any 
changes you want to make in the substrait integration test repo itself, I'll 
gladly do those reviews for you as well!
   > 
   > Hi @richtia , I just find in some confusion in 
[tpch_1_json](https://github.com/substrait-io/consumer-testing/blob/main/substrait_consumer/tests/integration/queries/tpch_substrait_plans/query_1_plan.json)
   > 
   > in general tpch1, the filter looks like <img alt="image" width="409" 
src="https://private-user-images.githubusercontent.com/48054792/338012378-859bb956-267a-4aea-8df2-ee25db096104.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTc5NzA1MjUsIm5iZiI6MTcxNzk3MDIyNSwicGF0aCI6Ii80ODA1NDc5Mi8zMzgwMTIzNzgtODU5YmI5NTYtMjY3YS00YWVhLThkZjItZWUyNWRiMDk2MTA0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjA5VDIxNTcwNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY5ZmUwNGZjNjJhYTBjNTUxZmM5YzYyZmVhNmRkOWZhZmNkMzcyYmU0MGY3OGM5YjY3ZDRiYTAyZjFlYWViNmYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.wj_ibmJPBVoBVNaQ60f3pUXZsVAx7zTzSg_ldge40tw";>
 but in this repo, the actual tpch_1 you use is like <img alt="image" 
width="468" src="https://priv
 
ate-user-images.githubusercontent.com/48054792/338012404-ab246b4d-e73a-4c11-a083-6951cc67c144.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTc5NzA1MjUsIm5iZiI6MTcxNzk3MDIyNSwicGF0aCI6Ii80ODA1NDc5Mi8zMzgwMTI0MDQtYWIyNDZiNGQtZTczYS00YzExLWEwODMtNjk1MWNjNjdjMTQ0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjA5VDIxNTcwNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVkMGU1YmE1MWMwMjFlNTg1OGFiOGUxNWI1MWZjOGJmYTBlNzVlMmRhNjZkYjZlMDU3OTQ3MzQxMTZkYzBkNzQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0._ZcGab4p3b-qwyTr66nViO67Z0FaQ8QFuCjcdMcM57E">
   > 
   > Is there any purpose of changing the expression?
   > 
   > Thanks a lot
   
   Ahh...these TPCH queries were pulled from somewhere else.  If there's a 
mistake in any, they should definitely be updated!  Feel free to file an issue 
or make the change yourself!
   
   Thanks for the catch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org