marvinlanhenke commented on code in PR #10972: URL: https://github.com/apache/datafusion/pull/10972#discussion_r1643868408
########## datafusion/core/src/datasource/physical_plan/parquet/statistics.rs: ########## @@ -552,6 +552,22 @@ make_data_page_stats_iterator!(MinInt32DataPageStatsIterator, min, Index::INT32, make_data_page_stats_iterator!(MaxInt32DataPageStatsIterator, max, Index::INT32, i32); make_data_page_stats_iterator!(MinInt64DataPageStatsIterator, min, Index::INT64, i64); make_data_page_stats_iterator!(MaxInt64DataPageStatsIterator, max, Index::INT64, i64); +make_data_page_stats_iterator!( + MinFloat16DataPageStatsIterator, + min, + Index::FIXED_LEN_BYTE_ARRAY, + f16 +); +make_data_page_stats_iterator!( + MaxFloat16DataPageStatsIterator, + max, + Index::FIXED_LEN_BYTE_ARRAY, + f16 +); +make_data_page_stats_iterator!(MinFloat32DataPageStatsIterator, min, Index::FLOAT, f32); Review Comment: I think `Float` (f32) and `Double` (f64) would be enough, in terms of naming. This would also be consistent with the row group stats iterators. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
