tshauck commented on code in PR #10972: URL: https://github.com/apache/datafusion/pull/10972#discussion_r1644588031
########## datafusion/core/src/datasource/physical_plan/parquet/statistics.rs: ########## @@ -552,6 +552,22 @@ make_data_page_stats_iterator!(MinInt32DataPageStatsIterator, min, Index::INT32, make_data_page_stats_iterator!(MaxInt32DataPageStatsIterator, max, Index::INT32, i32); make_data_page_stats_iterator!(MinInt64DataPageStatsIterator, min, Index::INT64, i64); make_data_page_stats_iterator!(MaxInt64DataPageStatsIterator, max, Index::INT64, i64); +make_data_page_stats_iterator!( Review Comment: Here's an example of what I mean... <img width="1130" alt="image" src="https://github.com/apache/datafusion/assets/421839/852f9b91-7b50-4903-8c59-cdd0bcd15fca";> Fixed length byte array is collected as `parquet::data_type::FixedLenByteArray`, which then means this doesn't match. Alternatively, using that data type in the macro causes later move issues when interacting with the calls to `min()` and `max()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
