alamb commented on code in PR #10972: URL: https://github.com/apache/datafusion/pull/10972#discussion_r1644659198
########## datafusion/core/src/datasource/physical_plan/parquet/statistics.rs: ########## @@ -552,6 +552,22 @@ make_data_page_stats_iterator!(MinInt32DataPageStatsIterator, min, Index::INT32, make_data_page_stats_iterator!(MaxInt32DataPageStatsIterator, max, Index::INT32, i32); make_data_page_stats_iterator!(MinInt64DataPageStatsIterator, min, Index::INT64, i64); make_data_page_stats_iterator!(MaxInt64DataPageStatsIterator, max, Index::INT64, i64); +make_data_page_stats_iterator!( Review Comment: I suggest we take a friendly look at how f16 for row groups work: https://github.com/apache/datafusion/blob/1cb0057b99a016ee982d34deb860cf7f4e52b845/datafusion/core/src/datasource/physical_plan/parquet/statistics.rs#L336-L340 I suspect the statistics in data pages will be encodd the same It is also possible that since f16 is a less common type, the parquet writer might write data page statistics for it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
