alamb commented on code in PR #11224: URL: https://github.com/apache/datafusion/pull/11224#discussion_r1663163729
########## datafusion/common/src/scalar/mod.rs: ########## @@ -6199,6 +6339,46 @@ mod tests { assert_batches_eq!(&expected, &[batch]); } + #[test] + fn test_map_display() { + let string_builder = StringBuilder::new(); + let int_builder = Int32Builder::with_capacity(4); + let mut builder = MapBuilder::new(None, string_builder, int_builder); + builder.keys().append_value("joe"); + builder.values().append_value(1); + builder.append(true).unwrap(); + + builder.keys().append_value("blogs"); + builder.values().append_value(2); + builder.keys().append_value("foo"); + builder.values().append_value(4); + builder.append(true).unwrap(); + builder.append(true).unwrap(); + builder.append(false).unwrap(); + + let map_value = ScalarValue::Map(Arc::new(builder.finish())); + + assert_eq!(map_value.to_string(), "[{joe:1},{blogs:2,foo:4},{},NULL]"); + + let ScalarValue::Map(arr) = map_value else { + panic!("Expected map"); + }; + + //verify compared to arrow display + let batch = RecordBatch::try_from_iter(vec![("m", arr as _)]).unwrap(); + let expected = [ Review Comment: 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org