Blizzara commented on code in PR #11224:
URL: https://github.com/apache/datafusion/pull/11224#discussion_r1663844385
##########
datafusion/common/src/scalar/mod.rs:
##########
@@ -3399,6 +3451,43 @@ impl fmt::Display for ScalarValue {
.join(",")
)?
}
+ ScalarValue::Map(map_arr) => {
+ if map_arr.null_count() == map_arr.len() {
Review Comment:
should this also have the assert like Struct?
```
// ScalarValue Map should always have a single element
assert_eq!(map_arr.len(), 1);
```
##########
datafusion/common/src/scalar/mod.rs:
##########
@@ -3471,9 +3560,6 @@ impl fmt::Debug for ScalarValue {
ScalarValue::List(_) => write!(f, "List({self})"),
ScalarValue::LargeList(_) => write!(f, "LargeList({self})"),
ScalarValue::Struct(struct_arr) => {
- // ScalarValue Struct should always have a single element
- assert_eq!(struct_arr.len(), 1);
-
Review Comment:
was this removal intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
