Blizzara commented on code in PR #11224:
URL: https://github.com/apache/datafusion/pull/11224#discussion_r1663876483
##########
datafusion/proto/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -1246,6 +1246,30 @@ fn round_trip_scalar_values() {
),
])))
.unwrap(),
+ ScalarValue::try_from(&DataType::Map(
+ Arc::new(Field::new(
+ "entries",
+ DataType::Struct(Fields::from(vec![
+ Field::new("key", DataType::Int32, true),
+ Field::new("value", DataType::Utf8, false),
+ ])),
+ false,
+ )),
+ false,
+ ))
+ .unwrap(),
+ ScalarValue::try_from(&DataType::Map(
+ Arc::new(Field::new(
+ "entries",
+ DataType::Struct(Fields::from(vec![
+ Field::new("key", DataType::Int32, true),
+ Field::new("value", DataType::Utf8, true),
+ ])),
+ false,
+ )),
+ true,
+ ))
+ .unwrap(),
Review Comment:
these would both be NULL maps, right? is it possible to add a test for a map
containing some values as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
