alamb opened a new pull request, #11337: URL: https://github.com/apache/datafusion/pull/11337
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Closes #. ## Rationale for this change While reviewing https://github.com/apache/datafusion/pull/11329 from @Blizzara I was confused about the use of `Arc<Expr>`: https://github.com/apache/datafusion/pull/11329#discussion_r1669084861 I looked into it more deeply and I found we can remove the `Arc` and a bunch of `clone` in `from_substrait_rex` This not only makes the code simpler, it is also more efficient. ## What changes are included in this PR? Return `Result<Expr>` rather than `Result<Arc<Expr>>` when creating DataFusion structures from substrait REX, and avoid unecessary copies the `Arc` was requiring ## Are these changes tested? Existing CI <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
