comphead commented on code in PR #11337:
URL: https://github.com/apache/datafusion/pull/11337#discussion_r1672490967
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -411,11 +411,11 @@ pub async fn from_substrait_rel(
from_substrait_rex(ctx, e, input.clone().schema(),
extensions)
.await?;
// if the expression is WindowFunction, wrap in a Window
relation
- if let Expr::WindowFunction(_) = x.as_ref() {
+ if let Expr::WindowFunction(_) = &x {
Review Comment:
I hoped clippy can find things like this 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
