ozankabak commented on issue #11359: URL: https://github.com/apache/datafusion/issues/11359#issuecomment-2220396909
> With this approach, function like limited_convert_logical_expr_to_physical_expr is no longer needed after this change. We have at least two such functions and it would be great to arrive at a design that eliminates such functions. Conceptually, we should have more info at the physical level (relative to logical level), so a refactor that makes `AggregateFunctionExpr` and likewise structs independent of logicals should be possible. I get the feeling that our dependency structure is currently more complex than it needs to be. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
