andygrove opened a new issue, #11359:
URL: https://github.com/apache/datafusion/issues/11359

   ### Is your feature request related to a problem or challenge?
   
   ### Is your feature request related to a problem or challenge?
   
   DataFusion 40.0.0 added a new `logical_args: Vec<Expr>` field to 
`AggregateFunctionExpr`, which seems confusing, and there is no documentation 
in this struct that explains what this field is used for.
   
   In DataFusion Comet, we do not use DataFusion's logical plan or expressions 
because we are translating an Apache Spark physical plan into a DataFusion 
physical plan and therefore we have no logical expressions to pass into this 
new field.
   
   I think at a minimum we should add some documentation around this new 
feature.
   
   ### Describe the solution you'd like
   
   _No response_
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   _No response_
   
   ### Describe the solution you'd like
   
   _No response_
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to