jayzhan211 commented on issue #11359: URL: https://github.com/apache/datafusion/issues/11359#issuecomment-2226859404
> Cool, maybe I could think about _pulling down_ functions trait from `expr` instead of _pulling up_ common things to `expr-common` 🤔 `ContextProvider` should be in the same crate with `AggregateUDF` because of `fn get_aggregate_meta(&self, name: &str) -> Option<Arc<AggregateUDF>>;`, and it has `TableSource` that import `LogicalPlan` and `Expr`. Therefore, UDF should be in the same crate with `Expr` and `LogicalPlan` 😢 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
