joroKr21 opened a new pull request, #11392:
URL: https://github.com/apache/datafusion/pull/11392
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #127.
## Rationale for this change
After #9436 it's possible to write and use all kinds of custom UDF functions
e.g. parameterized by additional arguments, but the issue is that equality and
hash code are based only on the name and signature. As such some plan rewrites
that put expressions in a hash set (e.g. `FilterPushDown`) violate this
assumption and we end up with semantically incorrect rewrites.
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
Added `equals` and `hash_value` methods to scalar, aggregate and window
UDFs. By default they delegate to the name and signature as before but custom
UDFs can override them to account for additional parameters. Unfortunately we
can't extend the `Eq` and `Hash` traits because they prevent us from using
trait objects.
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
Not yet, will work on a test.
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
## Are there any user-facing changes?
Yes, the UDF interfaces grow with two new functions.
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
